Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Ignite spell compatible with entities #746

Merged
merged 5 commits into from
Sep 28, 2024

Conversation

miyucomics
Copy link
Contributor

@miyucomics miyucomics commented Aug 26, 2024

Fixes this suggestion by making the Ignite Block spell able to ignite entities for eight seconds ( the vanilla duration for entities walking into fire ). It renames Ignite Block to just Ignite, adds a new argument type for "an entity or a vector", and changes the description for the spell to describe its new capabilities.

Copy link
Member

@object-Object object-Object left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about formatting, then I think LGTM.

@object-Object object-Object merged commit 2f96e46 into FallingColors:main Sep 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Suggestion] Expand Ignite Block's functionality
2 participants